This repository has been archived by the owner on Dec 3, 2024. It is now read-only.
Fix incorrect initialization of Info notification channel #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsodin
approved these changes
Jan 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using syncthing as a reference for handling notifications in my app, when I noticed that the "Info" channel appears to be incorrectly initialized.
It looks like it was intended for the Info channel not to vibrate, not to make sound, but only to show a badge. This might be redundant as it's possible every notification pushed to this channel already follows those standards, I am unsure. However, the code used to initialize the Info channel was actually modifying the already created Persistent channel, and thus did nothing.
This pull request fixes, what I think are typos which originated from a copy and paste of the code used to create the Persistent channel.
I think these lines should either be changed as per this pull request, or removed entirely.